Don't process constant() and env(); fixes #34 #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoOx
reviewed
Sep 19, 2018
Owner
MoOx
left a comment
There was a problem hiding this comment.
What if you have something like calc(env(safe-area-inset-left) + (100px * 2))?
Contributor
Author
|
It just skips the rule entirely. |
Owner
|
Yeah so don't you think we should only skip the part with it? The goal of this module is to reduce whenever it's possible. |
Contributor
Author
|
If you can get it to do that, that would be ideal. This is just a naive fix so that things don't break when using |
Owner
|
Yeah better than nothing. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #34
Don't process
constant()andenv()since these are non-calc values.Using solution provided by @guylando:
#34 (comment)